[4.2] The alias is already being used - updates#37017
[4.2] The alias is already being used - updates#37017roland-d merged 24 commits intojoomla:4.2-devfrom
Conversation
No idea if this is the _best_ way to do this so feedback appreciated. If/when accepted it can be applied to may similar use cases. pr for joomla#37013 create a menu item called test Try to create a second menu item also called test Before After And the link opens the existing menu item
|
You have to use a new language string else we get a fatal error without of sync languages |
no you don't. Did you actually test it? If you did and you got a fatal error please post the stack trace. |
|
Patch activated: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017. |
|
I assume thats with patchtester? You cannot apply a patch on to an existing one. You need to rest first. |
|
Of course have fetched before. And now resetted. Will try again. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017. |
|
I have tested this item ✅ successfully on 834c85c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017. |
|
Result: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017. |
|
@brianteeman I see a chance to improve this message (as i have monochrome in backend I tried to cklick on all strong parts of the text).
What do you think about where the string trashed is set only if the item is trashed? |
|
@chmst oh there are lots of possibilities for improvement. My main concern at this moment in time is if the code is correct. |
|
@chmst unless I am very much mistaken the change to have two strings - one for trashed and one for regular items - is very easy. It was just lazy coding before to have that language string. Once @HLeithner can confirm that he was wrong I will continue to work on this. |
|
@brianteeman yes, otherwise it would be tricky. If the user has a link, he can see that the item ist trashed, so maybe it is not necessary to mention it at all |
|
@chmst updated the PR so that the message is different if the duplicate is trashed or not |
administrator/components/com_contact/src/Table/ContactTable.php
Outdated
Show resolved
Hide resolved
|
Updated as requested by @roland-d |
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
|
@roland-d are you planning to include this PR into 4.2? Not sure if language files are updated on minor releases. |
That should not be a blocker for things merged into 4.2 :) |
|
Is this ever going to be merged? |
|
Thanks |
|
thanks |
joomla/joomla-cms#37385 - (только для pl-PL) joomla/joomla-cms#38825 + joomla/joomla-cms#38877 - (только для других языков) joomla/joomla-cms#38867 + joomla/joomla-cms#37017 + joomla/joomla-cms#38771 + joomla/joomla-cms#38761 + joomla/joomla-cms#39072 - (только для en-GB) + исправление различных формулировок
10 participants
pr for #37013
create a menu item called test
Try to create a second menu item also called test
Before
After
It only says trashed if it is trashed and the link opens the existing menu item
Plus
Also updates com_content, com_categories, com_newsfeeds by splitting the message into two (one if the item is trashed). These are simpler changes as they dont have item names or links
Also updates com_finder filters to use a correct language string. Its not an article and it cant be trashed ;)
com_banners has not been updated because there is an existing bug in that #37031